duplicate files found with collectPlugins()

[Darren]

In collectPlugins() is the following code, which is returning duplicate files from the list() method.

Code: Select all

    if (c.isDirectory) {
       var l = c.list()
       for (var idx in l) {
            var cPath = l[idx];
            Plugin.collectPlugins(cPath)
        }
    }


According to the docs on the File object, the list() method returns an array containing all the files found, and each file will be listed twice, once by numeric iterator, and once by named iterator.

To only receive one instance of each file listed, just use one iteration method or the other. But, if you use the "for(var idx in l)" technique then you will be using both iteration methods, and will receive two of each listed file.

An easy fix for this in the above code would be:

Code: Select all

    if (c.isDirectory) {
        var l = c.list()
        for (var idx=0; idx<l.length; idx++) {     // this line changed
            var cPath = l[idx];
            Plugin.collectPlugins(cPath)
        }
    }


[recliq]

the code mentioned was completely replaced by different search method in beta FW, which will be released soon.
Also the new method increases plugin collection speed. see here

[Darren]

Thanks, I saw that post after I had created my own method. It took me like 10 times reading the docs for the File object before I knew what they meant about the iterators, so I thought I'd share.

Based on the original function, I stayed with a native javascript method for collecting the plugins, as compared to piping a system call.

This native method takes under 150ms to collect the plugins, no matter how many files you have on your disks. It looks like the piped method is taking much longer than this if you have lots of files, even if you use the maxdepth option.

Code: Select all

Plugin.collectPlugins = function(path, level) {
   if(!level) var level=0;
   var c = new File(path);
   var l;
   if(level==1) l = c.list(/\.plugin\.js$|^plugins$/i);
   else l = c.list();
   for (var idx=0; idx<l.length; idx++) {
      if (l[idx].isDirectory) {
         if(level<3) Plugin.collectPlugins(l[idx].path, level+1)
      }
      else if (l[idx].isFile && l[idx].name.endsWith(".plugin.js")) {
         Plugin.pluginsPath.push(l[idx].path)
      }
   }
}