dan wrote:balthazar wrote:btw I noticed you put quotes around "bad" but I just re-read this thread and the only thing I said was logging and comments were a joke. I never said the code was bad.
And you know, for pretty much my entire time writing things in PHP pretty much everyone has always said the same thing "if you want to put code out there and have people try to update it themselves rather than come pester you everytime something breaks, comment comment comment."
No, these are not exactly pentagon encryptions algorithms or NASA rover OS, but as someone looking at your code NOT being the one that wrote it I have to go line by line tracing things through three different PHP files and multiple hundreds of lines of code trying to recreate what exactly is supposed to be in the .cache file.
With some simple commenting "call helper script to parse feed info and place it into .cache file in format: x:y:z" I can spend more of my time figuring out where it breaks down and less trying to figure out what it's doing in the first place.
And again my point was: If this doesn't work...why is it included?
Are you aware of the fact that this whole project is just possible because people spend their spare time to develop the system, plugins, etc? What have you done to make the wd tv a better device?
Well, I've spent the last week trying to get up to speed and figure out the YT plugin so I could fix it. I'm sorry, between work and whatnot it WILL take me more than a week to get up to speed on this.
Two simple points where all I put forth: Does this work, if not, why include it? It needs better logging to make life for you and whomever decides to try to fix it next time it breaks easier.
And yes, this is my spare time too.
***
