Plugin: MediaMark [internal] (WDLXTV 0.4.5.1+)

[txemix]

I noticed MediaMark (internal) fails when filename (or folder) has a quote (e.g. Grey's Anatomy), otherwise it's really great having it integrated to WDLXTV. (By the way, to bad we cannot have also a lite version of MediaNavigation, I think in-file navigation would be enough.)

[monkmad]

@recliq: I see in SVN, that you are moving to a DB (sqlite) based implementation for MediaMark. I think it is a step in the right direction. Also noticed that you provided a script to import the old log file into the database, good stuff. I'd like to test this feature out; are the changes ready to be taken out for a spin, or are there any other commits still waiting?

[recliq]

basically it's working, check out mm2db.pl in MediaMark dir...
I made a couple of changes to that yesterday, the one in svn still uses hardcoded files and some wrong paths... i guess you will figure it out
will commit enhanced version soon (along with some webinterface for importing/exporting mediaMark.log file)

EDIT: updated SVn with latest version of mm2db.pl

[monkmad]

I was eager and tested it before you posted the new mm2db.pl

Initial verdict is that the import seems to work; though you want to add some some error handling for those lines in the old mediaMark.log file which are invalid. They usually have the word "error" somewhere in them. Left unchecked, they insert garbage data in the hash column which looks like "ERROR opening file umsp://plugins/apple-trailers/apple-trailers..."
You can also check after importing with something like

Code: Select all

select * from mediamark where hash like "error%";

It should not affect functionality, but I think its better if things are clean.

Now, rather than telling you about errors and asking for a fix, I thought why not write the fix myself? It's just a couple of lines. I don't have access to SVN or the ability to attach files with posts, so pasting modified code below. This is for the latest mm2db.pl (from SVN), starting from line #78. Hope it helps.
(As usual, please test before committing )

Code: Select all

   my $COUNT = 0;
   my $ERR_RECORDS = 0;
   my $IMPORTED = 0;
    $BROWSER eq "true" and print "importing hashes, please wait...";
    while (<FILE>) {
        chomp($_);
#    print "$_\n";
        my @HASH = split(/;/, $_);
        my $HASH = $HASH[0];
        if (index(lc($HASH[0]),"error") >= 0) {
            if ($DEBUG eq "true") {
            print "Error found in log file. Skipping record # $COUNT ...\n";
            }
            $COUNT++;
            $ERR_RECORDS++;
           next;       
        }
        if ($DEBUG eq "true") {
            print "\nhash: $HASH";
        }
        my $CMD = "insert into mediamark (hash, time) values ('$HASH', strftime('%s','now'))";
        if ($DRY eq "true") {
            print "\n sql: $CMD\n";
        } else {
             &sql("$CMD");
        }
        $COUNT++;
        if ($BROWSER ne "true") {
            $IMPORTED = $COUNT - $ERR_RECORDS;
            printf("\rinserted %d hashes out of a total %d records\t", $IMPORTED, $COUNT);
        }
    }
    if ($BROWSER eq "true") {
        printf("\ninserted %d hashes\n", $IMPORTED);
    } else {
        if ($COUNT > 0) { print "[ ok ]"; }
        print "\n";
    }
    close(FILE);

I'll post more feedback when I'm near the box and can test the OSD.

[recliq]

you are right, there's no error handling for the .log yet, i cleaned it out by hand... (and tried to avoid inserting error strings in mediamark)
i'll work on both on the weekend..

EDIT: Having a look at your code... how about only two lines and have even stricter checking...

Code: Select all

if ($HASH =~ /^\w{16}$/) {

}

around the insert code.

EDIT 2: maybe you're also intrested in this

[monkmad]

Yeah, you are right; much simpler. Most of my code was around catching and logging the error statements; which an end user won't care about.

As for your other link, I don't have access to that forum yet.

[recliq]

try again now... you should have access now.

[gpica]

hello
didn't find a place where to post this issue about MM internal: hope here is ok

my MM is enabled and seems it's working: in .log file i can see listed the "checked as seen" movies.
the only problem is that i can't see the checkmark in the sheet (list or wall, either)

i have to say that i modified the xml of those sheets, there is something i could check on them? any tag that reports the position of the checkmark?

thanks in advance
g.

[gpica]

hello
didn't find a place where to post this issue about MM internal: hope here is ok

my MM is enabled and seems it's working: in .log file i can see listed the "checked as seen" movies.
the only problem is that i can't see the checkmark in the sheet (list or wall, either)

i have to say that i modified the xml of those sheets, there is something i could check on them? any tag that reports the position of the checkmark?

thanks in advance
g.

(quoting myself) - SOLVED

ok, found it
i just modified my xml for wall and list mode and introduced ckeckMark.png in my custom OSD
thanks anyway

[RavRob]

Is there an updated download link somewhere? Or I need to patch the *.js myself? Or what other options?

Thanks