Plugins collection speed up

[gendouhydeist]

@buhric
I've tried your modified wdext.app.bin but my wdtvlive doesn't boot up

[Buhric]

I have it running on Firmware v0.4.1.9-6 EXT3 version... I did not test it on other versions...

[Eugen1968]

I have it running on 1.02.21_B-RAD.CC_WDLXTV_LIVE-0.4.2.0 and it's working well.

[monkmad]

As discussed elsewhere, if the usb drive with your plugins folder has a lot of other files (in my case >1000, with lots of deep folder hierarchies), then the plugins collection function can still take a long time, as the "find" command searches through the whole drive to look for plugins.

If you have all your plugins neatly arranged in one folder at the root of the usb drive, you can modify the patch discussed above even further, to restrict the "find" command to a certain depth.

Basically, the following line in Plugin.collectPlugins

Code: Select all

var pfile = new File("| /usr/bin/find " + path + " -iname *.plugin.js");

becomes

Code: Select all

var pfile = new File("| /usr/bin/find " + path + " -maxdepth 4 -iname *.plugin.js");

This (in my case) looks only in the plugins folder at root and one additional level (e.g. /plugins/MovieSheets). Helped speed up the collection from 2.5 minutes to <10 seconds. You can experiment with the number passed to maxdepth to suit your folder hierarchy.

I'm not sure if there are others in the same situation; if anyone is interested, I can post a patched WDTVExt.app.bin

All the credit goes to pibos, sailort, recliq and buhric; I just tweaked their work by a tiny amount.

[Eugen1968]

I'm not sure if there are others in the same situation; if anyone is interested, I can post a patched WDTVExt.app.bin

@monkmad, post patched WDTVExt.app.bin, I won't try.

[monkmad]

@monkmad, post patched WDTVExt.app.bin, I wont try.

Not sure if you meant won't try to patch or won't try the file at all.

Here is the link WDTVExt.app.bin-plugin-collection-speedup.zip

[Darren]

Here's my own tweaked version of collectPlugins. I posted this in another thread, but I guess it should go here...

Based on the original function, I stayed with a native javascript method for collecting the plugins, as compared to piping a system call.

This native method takes under 150ms to collect the plugins, no matter how many files you have on your disks. It looks like the piped method is taking much longer than this if you have lots of files, even if you use the maxdepth option.

Code: Select all

Plugin.collectPlugins = function(path, level) {
   if(!level) var level=0;
   var c = new File(path);
   var l;
   if(level==1) l = c.list(/\.plugin\.js$|^plugins$/i);
   else l = c.list();
   for (var idx=0; idx<l.length; idx++) {
      if (l[idx].isDirectory) {
         if(level<3) Plugin.collectPlugins(l[idx].path, level+1)
      }
      else if (l[idx].isFile && l[idx].name.endsWith(".plugin.js")) {
         Plugin.pluginsPath.push(l[idx].path)
      }
   }
}


[recliq]

can this handle links and dereference them?
if not, it's not of much use as you will see with the next wdlxtv release...

[Darren]

Well, I can't plan for what I don't know about... :-)

Is there a post that details what's coming up?

And as far as dereferencing links, I suppose any script could do that, assuming a standard symlink is what you're talking about. But for ntfs/fat drives, I guess using links like that would be some strange hybrid?

[b-rad.cc]

https://svn.wdlxtv.com/